Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] V1: Fix OpenAPI validation errors #6997

Open
2 tasks done
pcfreak30 opened this issue Jan 6, 2025 · 0 comments
Open
2 tasks done

[BUG] V1: Fix OpenAPI validation errors #6997

pcfreak30 opened this issue Jan 6, 2025 · 0 comments
Labels
C-bug Category: Bug S-awaiting-triage Status: New issues that have not been assessed yet

Comments

@pcfreak30
Copy link

Bug Description

I have been working to automate CI generation of hyperswitch's SDK client in java at https://github.com/LumeWeb/hyperswitch-java-client/ and found the v1 has an error with openapigenerator.

There is a lot of unused models, but more there is some errors that need patching.

Unable to find image 'openapitools/openapi-generator-cli:latest' locally
latest: Pulling from openapitools/openapi-generator-cli
521f275cc58b: Pulling fs layer
4ec0d48772e2: Pulling fs layer
c206fa8d0304: Pulling fs layer
f36698d7f25c: Pulling fs layer
4f82fb5fa4a4: Pulling fs layer
4559053a904d: Pulling fs layer
7291391b1e6a: Pulling fs layer
4f82fb5fa4a4: Waiting
4559053a904d: Waiting
7291391b1e6a: Waiting
f36698d7f25c: Waiting
4ec0d48772e2: Verifying Checksum
4ec0d48772e2: Download complete
f36698d7f25c: Verifying Checksum
f36698d7f25c: Download complete
c206fa8d0304: Verifying Checksum
c206fa8d0304: Download complete
521f275cc58b: Verifying Checksum
521f275cc58b: Download complete
4f82fb5fa4a4: Verifying Checksum
4f82fb5fa4a4: Download complete
7291391b1e6a: Verifying Checksum
7291391b1e6a: Download complete
4559053a904d: Verifying Checksum
4559053a904d: Download complete
521f275cc58b: Pull complete
4ec0d48772e2: Pull complete
c206fa8d0304: Pull complete
f36698d7f25c: Pull complete
4f82fb5fa4a4: Pull complete
4559053a904d: Pull complete
7291391b1e6a: Pull complete
Digest: sha256:a3471717ed06ac2af7308f473a7b61e6985882b31c6c5c05d2a41515db3eff8a
Status: Downloaded newer image for openapitools/openapi-generator-cli:latest
Validating spec (/local/new_spec.json)
Errors:
	- paths.'/payments/{payment_id}/post_session_tokens'. Declared path parameter payment_id
	  needs to be defined as a path parameter in path or operation level
	- attribute paths.'/customers/payment_methods'(get).operationId is repeated
	- paths.'/customers/{customer_id}/mandates'. Declared path parameter customer_id needs to be
	  defined as a path parameter in path or operation level
	- paths.'/accounts/{account_id}/connectors'. Declared path parameter account_id needs to be
	  defined as a path parameter in path or operation level
	- attribute components.schemas.ApplePaySessionResponse.default is not of type `object`
Warnings: 
	- Unused model: PaymentLinkInitiateRequest
	- Unused model: WeChatPay
	- Unused model: PaymentsRequest
	- Unused model: OutgoingWebhookContent
	- Unused model: PaymentsDynamicTaxCalculationResponse
	- Unused model: ExtendedCardInfoResponse
	- Unused model: NextActionType
	- Unused model: PaymentMethodCollectLinkRequest
	- Unused model: PaymentLinkConfig
	- Unused model: PayoutListConstraints
	- Unused model: AdditionalPayoutMethodData
	- Unused model: PaymentMethodCollectLinkResponse
	- Unused model: OrderDetails
	- Unused model: MerchantConnectorId
	- Unused model: RoutableChoiceKind
	- Unused model: ExtendedCardInfo
	- Unused model: MobilePaymentNextStepData
	- Unused model: PayoutRetrieveBody
	- Unused model: ToggleDynamicRoutingQuery
	- Unused model: PaymentsDynamicTaxCalculationRequest
	- Unused model: RewardData
	- Unused model: ListBlocklistQuery
	- Unused model: PaymentListConstraints
	- Unused model: DefaultPaymentMethod
	- Unused model: DisplayAmountOnSdk
	- Unused model: ToggleDynamicRoutingPath
	- Unused model: OutgoingWebhook
	- Unused model: PaymentsRetrieveRequest
	- Unused model: PayoutRetrieveRequest
	- Unused model: PayoutLinkInitiateRequest

[error] Spec has 5 errors.

Expected Behavior

It should validate without errors (or ideally warnings)

Actual Behavior

It has both errors and warnings

Steps To Reproduce

create openapi_spec.json and run docker run --rm -v "${PWD}:/local" openapitools/openapi-generator-cli validate -i /local/openapi_spec.json

Context For The Bug

No response

Environment

github actions.

Have you spent some time checking if this bug has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

@pcfreak30 pcfreak30 added C-bug Category: Bug S-awaiting-triage Status: New issues that have not been assessed yet labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Bug S-awaiting-triage Status: New issues that have not been assessed yet
Projects
None yet
Development

No branches or pull requests

1 participant