Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide versioning of first v3.0.0 release #1102

Open
dlqqq opened this issue Nov 11, 2024 · 2 comments
Open

Decide versioning of first v3.0.0 release #1102

dlqqq opened this issue Nov 11, 2024 · 2 comments
Assignees
Labels
maintenance Change related to maintenance of the repository
Milestone

Comments

@dlqqq
Copy link
Member

dlqqq commented Nov 11, 2024

Problem

Currently, the v3-dev branch is failing the check-release workflow. The branch deviates from main at v2.26.0, and now that v2.28.0 exists, the workflow fails with the message:

ValueError: Tag v2.28.0 already exists
...
subprocess.CalledProcessError: Command 'jupyter-releaser draft-changelog' returned non-zero exit status 1.

Proposed Solution

This workflow can be fixed by updating the version of the v3-dev branch manually to some v3 version. We should decide how the first release of v3-dev will be versioned, since we will have to do this later anyways.

Using a pre-release will allow us to make breaking changes as needed when uncovering issues during usability testing. Therefore, it seems preferable to use a pre-release version for the first v3-dev release.

I recommend using the version 3.0.0-alpha.0 as the version of the first v3 release performed by Jupyter Releaser. This should be distributed as 3.0.0a0 on PyPI. This also seems aligned with the convention used by JupyterLab.

Contributors, please leave feedback in this issue.

Additional context

We have cut pre-releases of Jupyter AI in the past: https://github.com/jupyterlab/jupyter-ai/releases/tag/v2.10.0beta0

@dlqqq dlqqq added the enhancement New feature or request label Nov 11, 2024
@dlqqq dlqqq added this to the v3.0.0 milestone Nov 11, 2024
@dlqqq dlqqq self-assigned this Nov 11, 2024
@dlqqq dlqqq added maintenance Change related to maintenance of the repository and removed enhancement New feature or request labels Nov 11, 2024
@jtpio
Copy link
Member

jtpio commented Nov 12, 2024

I recommend using the version 3.0.0-alpha.0 as the version of the first v3 release performed by Jupyter Releaser. This should be distributed as 3.0.0a0 on PyPI. This also seems aligned with the convention used by JupyterLab.

Yes this sounds good 👍

@brichet
Copy link

brichet commented Nov 12, 2024

Sounds good to only cut pre-release for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Change related to maintenance of the repository
Projects
None yet
Development

No branches or pull requests

3 participants