-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make faiss-cpu
an optional dependency in v3.0.0
#1100
Comments
Hi! Official FAISS builds are available via the conda pytorch channel: https://github.com/facebookresearch/faiss/blob/main/INSTALL.md |
Thanks for the link @asadoughi! However, asking all conda users of |
Also, I understand that the |
Taking liberty to mention @h-vetinari as the only listed maintainer on conda-forge feedstock for @asadoughi do you think that there would be a chance for the FAISS team to collaborate with @h-vetinari on getting the conda-forge feedstock back to speed given the deprecation of
|
I'm hearing a lot of good things about https://github.com/lancedb/lancedb, I wonder how much effort it would be to allow one or the other. |
Hey 👋 Faiss has fallen off the radar a bit, because it was quite a handful to maintain (...for free and with no feedback or help from anyone...). If it turns out to be useful, it's not a big deal to bring it back up to speed. There's further optimization work possible (e.g. doing AVX2 or AVX512-enabled builds), but for now I've kept it running. Just saw that the bot didn't open a PR for 1.9, that should be easy to fix. Any help on the feedstock from interested parties is more than welcome.
Not involved there, but it has a healthy-looking feedstock in conda-forge. |
We really appreciate the effort you've put in to making |
Problem
Listing
faiss-cpu
as a required dependency has caused numerous issues for users.faiss-cpu
, therefore we havefaiss-cpu
listed as a required dependency.faiss-cpu
from Conda Forge does not install a Python package namedfaiss-cpu
, but instead a Python package namedfaiss
. This causespip check
to fail, sincefaiss-cpu
is not installed. Jupyter AI still works however, since both packages provide thefaiss
module that we import.Proposed Solution
faiss-cpu
an optional dependency./learn
.Additional context
The text was updated successfully, but these errors were encountered: