Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package_data_spec not supported anymore? #88

Open
martinRenou opened this issue May 8, 2021 · 4 comments
Open

package_data_spec not supported anymore? #88

martinRenou opened this issue May 8, 2021 · 4 comments

Comments

@martinRenou
Copy link
Member

Being able to pass a package_data_spec to create_cmdclass was quite handy to be able to include package_data as part of the wheel, but it seems to me that it's not supported anymore, or maybe I am missing something?

@blink1073
Copy link
Contributor

cf #69 (comment)

@martinRenou
Copy link
Member Author

I am not sure I understand everything there, how should one include package_data in the wheel now? I can see we can still use the MANIFEST and include_package_data=True to include data in the source dist.

@blink1073
Copy link
Contributor

@vidartf
Copy link
Collaborator

vidartf commented May 17, 2021

We provide a get_data_files function but recommend people use setup.cfg for non-glob-pattern data files.

Under the main use of globbing a bunch of folders, I assume get_data_files should do it, but what is the recommended way to ensure that this is only called after the build commands have run ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants