Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Add tests in test_xnelson_kernel.py #19

Open
anutosh491 opened this issue Jul 12, 2024 · 3 comments · May be fixed by #20
Open

TODO: Add tests in test_xnelson_kernel.py #19

anutosh491 opened this issue Jul 12, 2024 · 3 comments · May be fixed by #20

Comments

@anutosh491
Copy link
Contributor

The file says the following

#############################################################################
# TODO fake test to replace with test below when nelson is available
# as a package (for CI)
import unittest
class TestFake(unittest.TestCase):
def test_fake(self):
pass
#############################################################################

So currently no kernel tests are present I guess

@Hind-M
Copy link
Member

Hind-M commented Jul 15, 2024

It's actually just removing this and uncomment this IIRC.
I will need to update my working environment to send a PR to fix this, but I guess it would be easier/faster if you think you can open a PR to replace the TestFake since you most probably have something up to date :)

@anutosh491 anutosh491 linked a pull request Jul 16, 2024 that will close this issue
@anutosh491
Copy link
Contributor Author

anutosh491 commented Jul 16, 2024

Raised a PR simply uncommenting the above as you mentioned but some tests fail (Need to look into it but I'm on vacation :| )

@Hind-M
Copy link
Member

Hind-M commented Jul 16, 2024

Hum 🤔 so maybe something is missing or they need to be adapted... But no worries, there is no rush, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants