Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JWT token to be passed as a query param #124

Open
TannerPlauche opened this issue Jul 7, 2022 · 1 comment
Open

Allow JWT token to be passed as a query param #124

TannerPlauche opened this issue Jul 7, 2022 · 1 comment

Comments

@TannerPlauche
Copy link

FEATURE REQUEST

Allow JWT to be passed as a query parameter.

Currently nodebb-plugin-session-sharing detects the JWT via a domain specific cookie. This could be expanded to include a query parameter, for example www.mynodebb-forum.com?session-token=qweqwe.qweqwe.qweqwe.

The reasoning for this feature is that cookies cannot be set programmatically when opening a brownser tab/window from a mobile device. It is possible in some cases to pass cookies from fully native applications to webview components. That solution is only viable for webviews on fully native apps, and query params are universal and would apply to all platforms.

@waschinski
Copy link

That's a great feature request I'd like to see implemented.

As an inspiration, I like how FastComments implemented something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants