New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Performance: Tradeoff between a shared dict vs separate dict per method. #18

Open

ghost opened this issue Jun 4, 2020 · 1 comment

Labels

performance question

ghost commented Jun 4, 2020

Creating an issue for the TODO introduced in #17:

https://github.com/RelationalAI-oss/Salsa.jl/blob/705f61017439290bc811e496f0abf1978ac66799/src/default_storage.jl#L59-L67

We should do this investigation then either remove the TODO or make the change.

ghost added question performance labels

ghost mentioned this issue

Upstream from RelationalAI: Re-implement Salsa via new v2 API #17

Merged

Author

ghost commented Jun 4, 2020

When this is decided, it'll also affect these functions:
https://github.com/RelationalAI-oss/Salsa.jl/blob/705f61017439290bc811e496f0abf1978ac66799/src/default_storage.jl#L88-L113

NHDaly assigned NHDaly and unassigned NHDaly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment