Batch recover files in the recycle bin

[T-TRz879]

I think this function is very helpful for misoperation rm -rf *,But facing many problems, I sorted out several problems as follows:

1. The recovered parent directory does not exist
2. The revovered file/dir does exist
3. The parent directory of the recovered file is also in the recycle bin, but not in the same time subTrash folder.When the file and parent directory are in the same subTrash, it can recover the folder first
4. When recovered a file, cleanupTrash thread is working.it must conflict and will lead to incomplete recovery

[davies]

Yes, we could have a tool to recover a file or a directory recursively.

[T-TRz879]

If I can, I want to participate in the implementation of this function!!

[T-TRz879]

@xiaogaozi

[xiaogaozi]

You are very welcome to contribute code to the JuiceFS community, please read the Contributing Guide document for related information.

[T-TRz879]

ok,Thanks! :)

[T-TRz879]

@davies @xiaogaozi @Suave @suzaku
I wrote the design idea of batch recover. You can give me some advice.
批量恢复.md

[qingyunha]

Could we make the trash name exactly as it is, with the path included, so that we can just use "mv" to recover?

[T-TRz879]

I understand what you mean. The advantage of your idea is that you can let the user see the location before this file. I think that in this case, the value of the sub file / directory saved by subtrash should be saved in inode and attr. This can facilitate our mv. When we unlink, rename and rmdir, we need to consider the duplicate file names in subtrash