Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: modifiers in triggering sequence cause visible-backspaced to delete too many characters #561

Closed
drowningnewt opened this issue Sep 16, 2023 · 1 comment · Fixed by #605
Labels
bug Something isn't working

Comments

@drowningnewt
Copy link

Is your feature request related to a problem? Please describe.

When doing sequences, visible-backspaced will delete the entire sentence rather than just deleting inputs related to a sequence.
If I had a sequence that outputted "you" and tried to type "qwerty you" it will output "you" instead.

Describe the solution you'd like.

A sequence input mode that had the no visual delay factor from waiting for a timeout to end like visible-backspaced but with the output of hidden-delay-type. For the example above, "qwerty you" would actually be outputted rather than deleting everything then outputting the sequence.

Describe alternatives you've considered.

I've tried using hidden-delay-type, but I don't like having the visual delay from waiting for the sequence timeout to end before pasting the sequence leader on sequence termination.

Additional context

2023-09-16.11-40-07.mp4
@drowningnewt drowningnewt added the enhancement New feature or request label Sep 16, 2023
@jtroo
Copy link
Owner

jtroo commented Nov 4, 2023

The visible-backspaced option does behave in the desired manner in most cases. But since your sequence is ending on lalt, the fact that you're holding lalt means that the behaviour of the backspace keys changes.

There could be some code added to release all keys before outputting the sequence to fix this issue.

The workaround today is to not end sequences with a modifier key, and also ensure modifiers are released before ending a sequence.

@jtroo jtroo changed the title Feature request: sequence input mode like visible-backspaced but with hidden-delay-type output Bug: modifiers in triggering sequence visible-backspaced to delete too many characters Nov 4, 2023
@jtroo jtroo added bug Something isn't working and removed enhancement New feature or request labels Nov 4, 2023
@jtroo jtroo changed the title Bug: modifiers in triggering sequence visible-backspaced to delete too many characters Bug: modifiers in triggering sequence cause visible-backspaced to delete too many characters Nov 4, 2023
@jtroo jtroo linked a pull request Nov 4, 2023 that will close this issue
4 tasks
@jtroo jtroo closed this as completed in #605 Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants