-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore boolean attribute treatment from 3.x #504
Comments
3 tasks
I have this work in progress but I'm pausing it for now to focus on other priorities; I'll return to this before the jQuery 4.0.0 RC. |
mgol
added a commit
to mgol/jquery-migrate
that referenced
this issue
Oct 8, 2024
Restore & warn against: * boolean attributes set to something different than their lowercase names * boolean attributes queried when set to something different than their lowercase names * non-boolean non-ARIA attributes set to `false` Fixes jquerygh-504 Ref jquery/jquery#5452 Ref jquery/api.jquery.com#1243
PR: #540 |
mgol
added a commit
to mgol/jquery-migrate
that referenced
this issue
Oct 15, 2024
Restore & warn against: * boolean attributes set to something different than their lowercase names * boolean attributes queried when set to something different than their lowercase names * non-boolean non-ARIA attributes set to `false` Fixes jquerygh-504 Ref jquery/jquery#5452 Ref jquery/api.jquery.com#1243
mgol
added a commit
to mgol/jquery-migrate
that referenced
this issue
Oct 28, 2024
Restore & warn against: * boolean attributes set to something different than their lowercase names * boolean attributes queried when set to something different than their lowercase names * non-boolean non-ARIA attributes set to `false` Fixes jquerygh-504 Ref jquery/jquery#5452 Ref jquery/api.jquery.com#1243
mgol
added a commit
to mgol/jquery-migrate
that referenced
this issue
Oct 29, 2024
Restore & warn against: * boolean attributes set to something different than their lowercase names * boolean attributes queried when set to something different than their lowercase names * non-boolean non-ARIA attributes set to `false` Fixes jquerygh-504 Ref jquery/jquery#5452 Ref jquery/api.jquery.com#1243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See jquery/api.jquery.com#1243 & jquery/jquery#5452 for changes planned for 4.0. We should restore special boolean attributes treatment and warn if the setter is used with an unrecognized value. In the getter, warn if the value is different than the lowercased attribute name.
Remember to go through the list of boolean attributes in the spec and exempt any new values (like
until-found
for thehidden
attribute) from such a conversion. New attributes should not be added to the list but any changes in existing ones will need to be accounted for.The text was updated successfully, but these errors were encountered: