Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

APNS.send_notifications doesn't handle bad device token well #27

Open
ianlin0126 opened this issue Mar 15, 2014 · 1 comment
Open

APNS.send_notifications doesn't handle bad device token well #27

ianlin0126 opened this issue Mar 15, 2014 · 1 comment

Comments

@ianlin0126
Copy link

I'm observing an issue with the batch notifications method send_notifications

If one of the device token in the request is incorrect due to any reason, the batch notification would stop at the bad token without any error response. An example as the following:

  • T: device token, M: message
  • Send batch notifications for 3 messages T1-M1, T2-M2, T3-M3
  • If T2 is problematic, only T1-M1 would succeed. T3-M3 would fail. The request wouldn't have any error messages indicating that the request have failed

Is it possible to fix this issue?

@sdaswani-lookout
Copy link
Collaborator

Yes, I noticed this flaw in the logic too. One straightforward fix would be to handle exceptions on a individual basis and then report back any errors. Feel free to post a fix if you'd like.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants