Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soundfont classified wrongly as drums #18

Open
worikgh opened this issue Dec 31, 2020 · 1 comment
Open

Soundfont classified wrongly as drums #18

worikgh opened this issue Dec 31, 2020 · 1 comment

Comments

@worikgh
Copy link

worikgh commented Dec 31, 2020

I used a sounfont with these instruments (as identified by griode):

        Instrument(1, 0, 1126, Distorted), 
        Instrument(1, 1, 1126, Clean), 
        Instrument(1, 2, 1126, Chords), 
        Instrument(1, 3, 1126, Bass)

These were identified as drums because 1126 % 1000 > 100 by get_dk_and_font, I think.

Where does: i.bank % 1000 > 100 mean? Is that supposed to be a property of sound fonts?

@jpetazzo
Copy link
Owner

jpetazzo commented Jan 1, 2021

Hi!

If I remember well, I had noticed that in most sound fonts, the drum kits were on banks 100 to 127, and that it was a good heuristics to decide whether to map the instrument the "note" layout or to the "drum" layout.

To be honest, I don't know (and can't find any official info) to know if it was a good thing or just a lucky guess on my part.

I wonder what would be the best solution here?

  • some way in the interface to switch to a "note" layout even for drum patches?
  • adding the possibility of a small file to configure the sound font, e.g. if you have the file 2.sf2 and also 2.yml it would load that YAML and it could contain some overrides...?
  • find out what's the real rule about bank numbers?
  • something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants