genius.search_song returns 403 Forbidden #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes johnwmillr#287 by changing the User-Agent to the users device name instead of LyricGenius.
|
The more I think about this, the less I think it is an issue, at least for endpoints that require auhtentication. If someone is abusing it, their API key will just get blocked. |
johnwmillr
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
Thank you for your changes, @ItsJustAGitHubMichealWhosGonnaSeeIt5Ppl and @Vauth. I've made the User-Agent an optional configurable parameter that defaults to the user's system information. I refrained from using platform.uname() so as to avoid leaking personal information.
ItsJustAGitHubMichealWhosGonnaSeeIt5Ppl
deleted the
ItsJustAGitHubMichealWhosGonnaSeeIt5Ppl/issue287
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287 by changing the User-Agent to the users device name instead of LyricGenius.