Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Song and Album imports within classes #286

Closed
wants to merge 1 commit into from
Closed

Move Song and Album imports within classes #286

wants to merge 1 commit into from

Conversation

johnwmillr
Copy link
Owner

Fixes #285 by moving imports from top of file to within classes.

@johnwmillr johnwmillr requested a review from allerter December 13, 2024 06:37
@johnwmillr johnwmillr self-assigned this Dec 13, 2024
@allerter
Copy link
Contributor

#280 was already there, but this works too :)

@johnwmillr
Copy link
Owner Author

Closing in favor of #280.

@johnwmillr johnwmillr closed this Dec 13, 2024
@johnwmillr johnwmillr deleted the fix-circular-import-between-song-and-album branch December 13, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allerter allerter allerter approved these changes

Assignees

@johnwmillr johnwmillr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Album to Song class causes a circular import error
2 participants
@johnwmillr @allerter