Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable DynamoDB DocumentClient #9

Open
jacekelgda opened this issue Mar 23, 2018 · 0 comments
Open

Configurable DynamoDB DocumentClient #9

jacekelgda opened this issue Mar 23, 2018 · 0 comments

Comments

@jacekelgda
Copy link

jacekelgda commented Mar 23, 2018

https://github.com/johnagan/serverless-slack/blob/master/src/dynamo.js#L4

To work with the offline local environment using serverless plugins:

plugins:
  - serverless-dynamodb-local
  - serverless-offline

additional configuration of DocumentClient is required.
Since Dynamo service is a hardcoded dependency there is no way to inject it on the implementation level. Two ways of resolving this issue:

  1. Using env variables for DocumentClient config ( like in here, but with additional params: https://github.com/serverless/serverless-slack/blob/master/lib/models/team.js#L12 )
  2. Dependency injection model

Please discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant