New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

little optimization #1

Open

bkfox opened this issue Jul 11, 2012 · 1 comment

bkfox commented Jul 11, 2012

In the udp scapper, you should invert

foreach($infohash as $hash){
if(!preg_match('#^[a-f0-9]{40}$#i',$hash)){ throw new ScraperException('Invalid infohash: ' . $hash . '.'); }
}
if(count($infohash) > 74){ throw new ScraperException('Too many infohashes provided.'); }

by:

if(count($infohash) > 74){ throw new ScraperException('Too many infohashes provided.'); }
foreach($infohash as $hash){
if(!preg_match('#^[a-f0-9]{40}$#i',$hash)){ throw new ScraperException('Invalid infohash: ' . $hash . '.'); }
}

it should be better for perfs

Owner

johannes85 commented Jul 20, 2012

It would be nice if you can send me this change as pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment