Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redesign] Very aggressive buffering (or maybe wasting data) #986

Closed
dogtopus opened this issue Dec 25, 2024 · 2 comments
Closed

[Redesign] Very aggressive buffering (or maybe wasting data) #986

dogtopus opened this issue Dec 25, 2024 · 2 comments

Comments

@dogtopus
Copy link

I noticed that the network activity didn't stop after one song is fully buffered. The buffering also didn't seem to stop even after Finamp consumed more than 3x the amount of the data required to pull the first song so I suspect that it's trying to pull the entire queue. Although if I try to switch to next tracks Finamp would seemingly discard the buffer after only 2 switches, wasting the data it uses to pull the songs.

I'm running Finamp 0.9.12.

@dogtopus
Copy link
Author

Manually adjusting the buffer length in the audio service settings fixes this.

Not really an issue. Closing now.

@Chaphasilor
Copy link
Collaborator

Yeah I chose 10 minutes as the default to be tolerant against spotty connections while driving or commuting. I was annoyed that playback always paused on my daily commute with the stable version (or other media players).
Pre-caching a certain number of track isn't easy sadly, but we'll probably change the buffer size to be in bytes instead of seconds, because high-quality audio (like FLAC) will consume tons of RAM otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants