-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop not clearing playback session in dashboard if playback was already paused #961
Comments
For me on Android stopping actually never clears the session. Stopping without pausing resets the position to 0 seconds, and stopping after pausing first won't change the position at all. Which platform are you on? |
Interesting, in my case the dashboard never shows the playback as stopped. It just shows as paused and then after "update frequency" seconds resets to 0 seconds. Getting the update to properly reflect the status should be easy, I'm not sure about the rest of the behavior. I'll take a lool tomorrow, since I want playback reporting to be as solid as possible! |
@HamletDuFromage that is actually by design! As long as Finamp is running and "playing" something (not stopped), it will also keep the session in the server dashboard active. |
Ah I see, my bad then :o |
No worries! |
Playback did indeed return to 0 after swiping down, and in term I assume will disappear from the dashboard. Thanks :) |
>We are aware that it's not ideal and will add a proper button for this in the future :) Off topic, but it felt natural for me when I first used the app. I tried to stop playback by swiping left/right, but it changed song instead, so swiping down was the only option I could think of and it worked |
@ilia-21 yeah we'll definitely keep that gesture, but it certainly isn't super obvious to find. A properly labeled button in addition to the gesture should fix that. |
Okay, so after spending way to long on this issue (around 3h), I think I finally fixed it. I was chasing ghosts for the longest time, the final fix wasn't too complicated. Hopefully this doesn't break anything else... |
Hello! Thank you for making this amazing app!
I'm using it with jellyfin-rpc to show my activity on discord. I noticed that when I pause the song and stop playback it still shows up in my profile. jellyfin-rpc takes data from the dashboard so I checked it, and there still was my session. I tried closing the app, even killing it, session was still there. Important that it doesn't happen if I stop the playback (swipe down) while song is still playing.
Repro steps:
The text was updated successfully, but these errors were encountered: