Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some 2 digit and all 3 digit track numbers are broken #960

Open
felix920506 opened this issue Nov 20, 2024 · 6 comments
Open

Some 2 digit and all 3 digit track numbers are broken #960

felix920506 opened this issue Nov 20, 2024 · 6 comments
Labels
bug Something isn't working design Design changes high priority redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@felix920506
Copy link

Some 2 digit track numbers and all 3 digit track numbers are shown in 2 lines. See the attached screenshots for how they are displayed.

Screenshots are taken on my iPhone 13 mini, but the 3 digit ones are also broken on my ChromeOS tablet running the Android version.

This is using the beta version from TestFlight / Google play

image

image

@Whoever4976
Copy link
Contributor

Whoever4976 commented Nov 20, 2024

I have a more severe version of this issue on my device. All 2 digit numbers get split into two rows, and 3 digit numbers get truncated two the first two digits, which are also shown in two rows. I haven't verified this but i think that this bug only occurred after the latest beta update (0.9.12)

Here some additional info to help reproduce the bug:

greatlte:/ $ wm size
Physical size: 1440x2960
greatlte:/ $ wm density
Physical density: 480
greatlte:/ $ dumpsys window windows| sed -n '/Window .*StatusBar.*:/,/Window .*:/p'| grep 'Requested'
Requested w=1440 h=84 mLayoutSeq=3515

(Size of the notification bar: 84 pixels)
Version of Finamp: 0.9.12
Android version: 14

Screenshots:

Two digit numbers in two rows:
Screenshot_20241120-211403_Finamp

Three digit number being truncated (Track 100 & 101):
Screenshot_20241120-211420_Finamp

Full Screenshot:
Screenshot_20241120-211818_Finamp

@Chaphasilor
Copy link
Collaborator

Yeah this is definitely a side effect from the redesign of the list tiles in the latest beta version. Thanks for reporting it.

I wasn't even aware there are 3-digit index numbers (silly me), and I'm not sure I'll like the fix for it. But I'll definitely fix it for the next update! Not sure when that will drop.

@Chaphasilor Chaphasilor added bug Something isn't working design Design changes high priority redesign-beta Issues related to the beta/redsigned version of Finamp labels Nov 21, 2024
@Chaphasilor Chaphasilor moved this to In Progress in Finamp Redesign Nov 21, 2024
Chaphasilor added a commit that referenced this issue Nov 22, 2024
@Chaphasilor
Copy link
Collaborator

Should be fixed in the next beta update!
For longer (wider) track numbers the title might get shifted to the right. That isn't ideal and might look weird in some cases, but I prefer it over allocating more space for the track numbers that isn't used in the majority of cases.

@Chaphasilor Chaphasilor moved this from In Progress to Done in Finamp Redesign Nov 22, 2024
@felix920506
Copy link
Author

Maybe dynamically set how wide the track number column should be according to how many items is in the album / playlist?

@Chaphasilor
Copy link
Collaborator

The issue is that the rendering is done in each track tile in isolation, meaning we would need to pass around information about what the highest/widest sibling index is. I considered it, but wanted to avoid it. It's not worth the trouble for an alignment issue :)

@Titaniumtown
Copy link

I can still reproduce this. Also noticed this in the same album @felix920506 haha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design Design changes high priority redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
Status: Done
Development

No branches or pull requests

4 participants