Images Fail to Download to External Storage

[gozes]

So I joined the beta today and trying to download some of my library to the SD card on my DAP. However as you can see from the logs it looks like I'm getting a lot of failed image downloads. Looking at the SD card it looks like the songs downloaded fine but I haven't tried all of them to be sure. It's hard for me to tell if the missing images would cause any issues. I usually add the cover art to every song when I tag them so it's unclear to me what images it's trying to download

[gozes]

So tapping around it seems that the images that fail to download are the ones that will be used in the player and as the album cover as songs seem to play fine in offline mode I just have a bunch of blurry colors that resemble the cover art instead of the actual cover art. The same is true for the artist tab in offline mode. I find it a bit strange it it's trying to pull down the album cover when I embedded the cover art on each song when I tag them so I would think I finamp would just look to see if track one has an image embedded then use that instead of trying to download it. Reducing the number of runners from 10 to 5 didn't really do much aside from making the process slower

[Chaphasilor]

Yes, that is a known issue that I also mentioned in my comment #842 (comment)

I've managed to pinpoint this to images failing to download for any tracks where no other track from that album has already been downloaded. It seems to be a permission issue, but I'm not yet totally sure why it happens.

Finamp doesn't look at the tags of files at all, all information is fetched from the server. That's by design, and in some cases like when transcoding is the only way to get the data.

[gozes]

@Chaphasilor so it seams that even after given it the permissions by adb it still fails to get images. I tried both repair and sync but they both fail to get the images. logs for it look identical to the ones I already shared so didn't upload them again

[Chaphasilor]

Maybe @Komodo5197 could take a look at this, they have more experience with the download system. I'd imagine it's a rather simple issue, since downloading the tracks itself works fine, but I'm not sure where to look.

[gozes]

Let know what support you would need from my side. Happy to help get this fix :) .

…

On Tue, Nov 19, 2024, 12:35 Chaphasilor ***@***.***> wrote: Maybe @Komodo5197 <https://github.com/Komodo5197> could take a look at this, they have more experience with the download system. I'd imagine it's a rather simple issue, since downloading the tracks itself works fine, but I'm not sure where to look. — Reply to this email directly, view it on GitHub <#955 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE2QWVBF2UNZ4WCJ3Y44RL2BMWB5AVCNFSM6AAAAABRZ5OC7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBVGU4DSMJTHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Komodo5197]

It seems like android permissions refuse to allow any file without a valid music file extension to be written to the /Music folder. If you use the /Documents directory, or write all the images as .mp3, everything works fine.

[gozes]

It seems like android permissions refuse to allow any file without a valid music file extension to be written to the /Music folder. If you use the /Documents directory, or write all the images as .mp3, everything works fine.

All my music is in flac. All the music is going into /Music/finamp in the sd card

[gozes]

Yup, deleted everything and set the location to /Downloads and the images started to show up

[Chaphasilor]

I'm wondering if it's best to just always save the images to the internal location, and only save the actual tracks to the custom ones.
Not sure how complicated that would be, but given that it already works when downloading on track to the internal location and the remaining tracks to a custom one, it should be doable.

Saving the images with a different extension kind of defeats the purpose of saving them in a user-accessible location anyway.

[gozes]

Hmm that may get troublesome with a large library. For example my hiby m300 has tiny tiny amounts of internal storage but It can take up to a 2TB micro SD card. That said if storing images for 2TB worth of music only comes up to maybe a few hundred megabytes then maybe it makes sense .

…

On Tue, Nov 19, 2024, 22:56 Chaphasilor ***@***.***> wrote: I'm wondering if it's best to just always save the images to the internal location, and only save the actual tracks to the custom ones. Not sure how complicated that would be, but given that it already works when downloading on track to the internal location and the remaining tracks to a custom one, it should be doable. Saving the images with a different extension kind of defeats the purpose of saving them in a user-accessible location anyway. — Reply to this email directly, view it on GitHub <#955 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE2QWXSITXZQ7E4R3AS2ID2BO6YXAVCNFSM6AAAAABRZ5OC7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWHEYTOMRSGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>