Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redesign Beta] Player screen has the wrong transition direction #948

Open
NutchapolSal opened this issue Nov 8, 2024 · 1 comment
Open

Comments

@NutchapolSal
Copy link

NutchapolSal commented Nov 8, 2024

The design seems to imply that the player screen should come in from the bottom, which tracks with the down arrow close button and the swipe down gesture. However currently the player does a transition from the right which implies a "swipe right to go back" but that conflicts with previous track gesture. A slide-in from bottom would make more sense.

maybe related to #619?
also does this have something to do with the side-by-side design on tablet?

Finamp version: 0.9.11
iOS version: 18.0.1

@jmshrv
Copy link
Owner

jmshrv commented Nov 8, 2024

The "lore" to this is that when I implemented it years ago as an Android user, the default animation happened to line up, and I didn't really test on iOS at that point. A proper swipe animation would be nice though :) (especially since I think Flutter/Android has changed the default animation?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants