Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] When removing a song from the queue the queue becomes an 'endless' grey screen #79

Closed
bambadon opened this issue Jul 18, 2021 · 3 comments

Comments

@bambadon
Copy link

Expected behavior: when you open up the queue and scroll to the bottom of it, the view will 'bounce' and stop you from scrolling further down. You can remove songs from this queue by swiping them to the left.

However on certain queues (I think long ones, I can't replicate it on smaller queues i.e. if I only play an album with a limited number of tracks and those compose of the queue) if you remove a few songs from the queue and scroll all the way down there's a grey zone below the queue. You can keep scrolling forever.

Tested on iPadOS.

@jmshrv
Copy link
Owner

jmshrv commented Jul 18, 2021

Could you send your main thread logs when this happens? I'm pretty sure I know what the issue is. If you don't want to send all of your logs (next update will hide the base URL), just long press on the latest error log, it should say something about an index.

@bambadon
Copy link
Author

This is the latest error after triggering this bug:

[Flutter/SEVERE] 2021-07-18 12:31:49.381413: RangeError (index): Invalid value: Not in inclusive range 0..100: 101

#0 _GrowableList.[] (dart:core-patch/growable_array.dart:254)
#1 _QueueListState.build.. (package:finamp/components/PlayerScreen/QueueList.dart:35)
#2 SliverChildBuilderDelegate.build (package:flutter/src/widgets/sliver.dart:455)
#3 SliverMultiBoxAdaptorElement._build (package:flutter/src/widgets/sliver.dart:1213)
#4 SliverMultiBoxAdaptorElement.createChild. (package:flutter/src/widgets/sliver.dart:1226)
#5 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2535)
#6 SliverMultiBoxAdaptorElement.createChild (package:flutter/src/widgets/sliver.dart:1219)
#7 RenderSliverMultiBoxAdaptor._createOrObtainChild. (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:349)
#8 RenderObject.invokeLayoutCallback. (package:flutter/src/rendering/object.dart:1889)
#9 PipelineOwner._enableMutationsToDirtySubtrees (package:flutter/src/rendering/object.dart:912)
#10 RenderObject.invokeLayoutCallback (package:flutter/src/rendering/object.dart:1889)
#11 RenderSliverMultiBoxAdaptor._createOrObtainChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:338)
#12 RenderSliverMultiBoxAdaptor.insertAndLayoutChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:484)
#13 RenderSliverList.performLayout.advance (package:flutter/src/rendering/sliver_list.dart:239)
#14 RenderSliverList.performLayout (package:flutter/src/rendering/sliver_list.dart:282)
#15 RenderObject.layout (package:flutter/src/rendering/object.dart:1779)
#16 RenderSliverEdgeInsetsPadding.performLayout (package:flutter/src/rendering/sliver_padding.dart:137)
#17 RenderSliverPadding.performLayout (package:flutter/src/rendering/sliver_padding.dart:371)
#18 RenderObject.layout (package:flutter/src/rendering/object.dart:1779)
#19 RenderViewportBase.layoutChildSequence (package:flutter/src/rendering/viewport.dart:510)
#20 RenderViewport._attemptLayout (package:flutter/src/rendering/viewport.dart:1574)
#21 RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:1483)
#22 RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:1636)
#23 PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:881)
#24 RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:462)
#25 WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:876)
#26 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:328)
#27 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1144)
#28 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1082)
#29 SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:998)
#30 _rootRun (dart:async/zone.dart:1354)
#31 _CustomZone.run (dart:async/zone.dart:1258)
#32 _CustomZone.runGuarded (dart:async/zone.dart:1162)
#33 _invoke (dart:ui/hooks.dart:163)
#34 PlatformDispatcher._drawFrame (dart:ui/platform_dispatcher.dart:259)
#35 _drawFrame (dart:ui/hooks.dart:126)

@jmshrv
Copy link
Owner

jmshrv commented Aug 6, 2021

Fixed in c8f7672

@jmshrv jmshrv closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants