Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support word-by-word time synced lyrics #780

Closed
Maxr1998 opened this issue Jun 15, 2024 · 4 comments
Closed

Support word-by-word time synced lyrics #780

Maxr1998 opened this issue Jun 15, 2024 · 4 comments

Comments

@Maxr1998
Copy link
Collaborator

There LRC format has an extension that supports syncing lyrics word-by-word. Jellyfin doesn't explicitly support this, but instead simply forwards these timing tags as a part of the lyrics line and expects the client to handle them (see here).

Currently, Finamp simply displays these word time tags:
Screenshot_20240615_022625.png

Ideally, it should fully support them, but at first simply hiding them would be a good start.

@Chaphasilor
Copy link
Collaborator

The issue you linked is a bit outdated. The most up-to-date discussion I'm aware of is karaoke-dev/LrcParser#40
So I consider word-by-word lyrics to be unsupported by Jellyfin at the moment, and would like to avoid adding client-side parsing for this.
Maybe back up your current lyrics (e.g. by renaming to .lrc.bak) and then use a script to strip out the timestamps in the actual lyrics file?

@Maxr1998
Copy link
Collaborator Author

So I consider word-by-word lyrics to be unsupported by Jellyfin at the moment, and would like to avoid adding client-side parsing for this.

I see, so we're basically waiting for the library to be fixed and then Jellyfin to offer an additional API with word-by-word support?

Maybe back up your current lyrics (e.g. by renaming to .lrc.bak) and then use a script to strip out the timestamps in the actual lyrics file?

Currently it's only a single file so not a real issue, I'd just love to have it supported so that I can grab more of these types of lyrics. But for now I'll wait.

@andy840119
Copy link

LrcParser package is upload and this update is focus on parsing the time-tag inside the lyric (see A2 extension in the wiki: https://en.wikipedia.org/wiki/LRC_(file_format))
This issue might resolved after Jellyfin upgrade the package.

@Chaphasilor
Copy link
Collaborator

Since this was added in Jellyfin 10.10, I'll consider this resolved. Updating downloaded lyrics isn't possible without re-downloading at the moment, but that's a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants