Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download individual songs. #62

Closed
Bitwolfies opened this issue Jul 12, 2021 · 9 comments
Closed

Download individual songs. #62

Bitwolfies opened this issue Jul 12, 2021 · 9 comments
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@Bitwolfies
Copy link

If there’s an option for it I can’t find it, would be a nice qol option to add if possible.

@jmshrv
Copy link
Owner

jmshrv commented Jul 13, 2021

This should be easy to add, I think I did the backend stuff for it a while ago. The only issue would be whether or not to also save the parent. Having the song only show up in the songs tab will be a bit clunky, but you could also argue that downloading one song in an album shouldn't download the whole album.

@Bitwolfies
Copy link
Author

This should be easy to add, I think I did the backend stuff for it a while ago. The only issue would be whether or not to also save the parent. Having the song only show up in the songs tab will be a bit clunky, but you could also argue that downloading one song in an album shouldn't download the whole album.

If you mean should it still display as an album even with one song, id say yes thats how id prefer it.

@drazil100
Copy link

Same. I never use the songs tab in any music app I ever use. Anything I have that isn't part of an album I go out of my way to edit the metadata on to say it's album is "No Album" by "Various Artists" so I always know where to find the loose songs. If I am only downloading part of an album id still like to find it in the album I know it's a part of.

@perniczech
Copy link

I'm with the others on this one, I just tried the app today (was waiting for a Play Store release, I'm lazy) and it actually threw me off a little when I added a single song into a test playlist, downloaded the playlist and then didn't see the song's album in the album section.

@jmshrv
Copy link
Owner

jmshrv commented Jul 14, 2021

I could probably make it so that downloading a single song also adds the album to offline mode.

@Bitwolfies
Copy link
Author

I could probably make it so that downloading a single song also adds the album to offline mode.

That is the best course of action imo.

@rodcramp
Copy link

rodcramp commented Aug 7, 2022

Linked with downloading, when downloading a Genre ALL tracks, i.e. likely different Genres, from an album are downloaded.
This would be okay if in offline mode you can filter by Genre, however at this point you can't..
(Am a N00B, apologies if not appropriate to mention this on this #)

@jmshrv
Copy link
Owner

jmshrv commented Aug 15, 2022

Going to note that in #213 as I will need to model genres, which may be pretty complex

@Chaphasilor Chaphasilor moved this to In Progress in Finamp Redesign Jan 25, 2024
@Chaphasilor Chaphasilor moved this from In Progress to Done in Finamp Redesign Jan 25, 2024
@Chaphasilor
Copy link
Collaborator

@Bitwolfies the download system has been improved as part of the redesign beta. You can now download individual songs using the song menu.
You can check the beta out here: https://github.com/jmshrv/finamp/releases/tag/0.9.2-beta

I'll close this issue for now since it should be resolved.

@Chaphasilor Chaphasilor added the redesign-beta Issues related to the beta/redsigned version of Finamp label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
Status: Done
Development

No branches or pull requests

6 participants