Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded items in playlists don't show up as downloaded songs within a given album #420

Closed
StayBlue opened this issue Mar 9, 2023 · 2 comments
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@StayBlue
Copy link

StayBlue commented Mar 9, 2023

Sorry if the title of this issue is a bit confusing. I am unsure if this is intentional, a bug, or needs to be added, but just to be sure, I'll explain the problem anyway. Additionally, I would guess that this issue being fixed would be contingent on #213 also being fixed.

After downloading a playlist of songs and entering offline mode, only the downloaded playlist will appear as downloaded, not the individual albums. Let me provide an example. Say you download a playlist containing four songs in an album, and an album contains ten songs. In offline mode, while viewing your albums, you would expect to see the album, and you can play the four songs that you downloaded within that album. Unfortunately, the only way to play those four songs that you have downloaded would be to open up the playlist where you downloaded those four songs until you download the entire album.

I wouldn't say this is a huge issue, but it'd be a nice-to-have.

Edit: Fixed the wrong issue being referenced.

@StayBlue
Copy link
Author

StayBlue commented Aug 29, 2023

Referencing #462 as a result of a comment that @jmshrv made in said issue.

@Chaphasilor Chaphasilor moved this to In Progress in Finamp Redesign Jan 25, 2024
@Chaphasilor Chaphasilor moved this from In Progress to Done in Finamp Redesign Jan 25, 2024
@Chaphasilor
Copy link
Collaborator

@StayBlue the download system has been improved as part of the redesign beta. Tracks should now be matched between playlists and albums, and album meta data will also be downloaded for the offline mode for each song in a playlist. You can check it out here: https://github.com/jmshrv/finamp/releases/tag/0.9.2-beta

I'll close this issue for now since it should be resolved.

@Chaphasilor Chaphasilor added the redesign-beta Issues related to the beta/redsigned version of Finamp label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
Status: Done
Development

No branches or pull requests

2 participants