Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Long song titles are cut off in player view #416

Open
PowerUser64 opened this issue Mar 5, 2023 · 7 comments
Open

Bug - Long song titles are cut off in player view #416

PowerUser64 opened this issue Mar 5, 2023 · 7 comments
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@PowerUser64
Copy link

In the player view, song titles that are too big to fit in the song title text box are cut off, so you can't read the whole title.

example:

Notice how the song's title text fades out on the right. There is currently no way to know what the full title of the song is in this view.

a soultion

A way to solve this would be to add marquee to the text so it scrolls from right to left to reveal the whole title.

@PowerUser64
Copy link
Author

Related: #392

@seniorm0ment
Copy link

I assume #220 redesign would resolve this

@jmshrv
Copy link
Owner

jmshrv commented Jul 26, 2023

A marquee would be nice, I'll implement it for names. In the redesign, album names are pretty small so it shouldn't be an issue.

@Chaphasilor Chaphasilor moved this from Todo to UI Issues - TODO in Finamp Redesign Jan 5, 2024
@Chaphasilor Chaphasilor moved this from UI Issues - TODO to Todo in Finamp Redesign Jan 25, 2024
@Ivanf1
Copy link

Ivanf1 commented Mar 30, 2024

Hello!
I also think a marquee would be nice for long names. The following video shows a possible solution.

marquee_name_test.mp4

Here is the version used in the video https://github.com/Ivanf1/finamp/tree/marquee

@Chaphasilor
Copy link
Collaborator

It would be nice if the marquee could be a fallback-solution that is only used if the title really doesn't fit. Because the marquee is always a single line, and by default the title is shown over two lines, increasing how much info can be shown at once.

@Ivanf1
Copy link

Ivanf1 commented Mar 30, 2024

Hi! Yes, I agree, that would be a better solution. I updated the version at https://github.com/Ivanf1/finamp/tree/marquee to implement this. Now the marquee is used only if the song name would need more than two lines to be displayed fully.

Let me know what you think!

@Chaphasilor Chaphasilor added the redesign-beta Issues related to the beta/redsigned version of Finamp label May 19, 2024
@Chaphasilor
Copy link
Collaborator

@Ivanf1 sorry for missing this! That change looks really nice, and I'd be happy to accept a PR for this!
There's also #754 which does something similar, but for the track menu. But I think your change is still a nice addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
Status: Todo
Development

No branches or pull requests

5 participants