-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug - Long song titles are cut off in player view #416
Comments
Related: #392 |
I assume #220 redesign would resolve this |
A marquee would be nice, I'll implement it for names. In the redesign, album names are pretty small so it shouldn't be an issue. |
Hello! marquee_name_test.mp4Here is the version used in the video https://github.com/Ivanf1/finamp/tree/marquee |
It would be nice if the marquee could be a fallback-solution that is only used if the title really doesn't fit. Because the marquee is always a single line, and by default the title is shown over two lines, increasing how much info can be shown at once. |
Hi! Yes, I agree, that would be a better solution. I updated the version at https://github.com/Ivanf1/finamp/tree/marquee to implement this. Now the marquee is used only if the song name would need more than two lines to be displayed fully. Let me know what you think! |
In the player view, song titles that are too big to fit in the song title text box are cut off, so you can't read the whole title.
example:
Notice how the song's title text fades out on the right. There is currently no way to know what the full title of the song is in this view.
a soultion
A way to solve this would be to add marquee to the text so it scrolls from right to left to reveal the whole title.
The text was updated successfully, but these errors were encountered: