Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetItems function throws Error 500 when viewing music videos #397

Open
Behem07h opened this issue Feb 4, 2023 · 14 comments
Open

GetItems function throws Error 500 when viewing music videos #397

Behem07h opened this issue Feb 4, 2023 · 14 comments
Labels
awaiting response / stale Issue is possibly outdated or waiting for user feedback

Comments

@Behem07h
Copy link

Behem07h commented Feb 4, 2023

When logged into an account with a music video library, entering finamp immediately throws an error 500 and finamp fails to load all tabs except the playlists tab.

Finamp log: https://pastebin.com/ChWKdQRn
Jellyfin log: https://pastebin.com/LgRk3jGu

@jmshrv
Copy link
Owner

jmshrv commented Feb 4, 2023

Ah, I didn't know you were using music videos. Finamp hasn't been tested on them, so I can't say how well they work. I'll have a look to see how they're implemented, and if they work similarly to regular music I'll get some initial support (although actual video playback is out-of-scope for now)

@Behem07h
Copy link
Author

Behem07h commented Feb 4, 2023

It seems like finamp actually already has the ability to play video from the files i'm using (mine are all mkv), as i'm able to play from the playlist tab and the video shows up.
However there seems to be a bug because the music + video plays part way and then goes back to the start, while the scrubber remains at the furthest timestamp that it played to

@jmshrv
Copy link
Owner

jmshrv commented Feb 4, 2023

The video plays? Could you send a screenshot? That would be super weird lol

@Behem07h
Copy link
Author

Behem07h commented Feb 4, 2023

oh wait, no it doesnt xD, my bad. It does play the audio and show the thumbnail though, as well as the issue where it restarts half way. I must be remembering another app, i've been looking through so many that its all a bit fuzzy

@Behem07h
Copy link
Author

Behem07h commented Feb 23, 2023

i'd like to expand on this issue by adding that even just having a non music type library attached to the jellyfin account causes finamp to cease functions on all library types

for example, i have a jellyfin account which accesses both a music video library and a music library. when loading it in finamp, my music library appears completely empty save for the playlists tab, and music from the music library played via the playlist tab load (album art and song length show) but fails to play (stays at 0:00 indefinitely)

i have confirmed that this is not the case in the official jellyfin client (although the official client seems to have it's own issues with music libraries)

@jmshrv
Copy link
Owner

jmshrv commented Feb 23, 2023

What media types are the libraries, and are you still trying to play music from a music video library? My Jellyfin has music and video libraries, and it functions correctly

@Behem07h
Copy link
Author

there is one music video library of mkv files and one music library of mka files, i am trying to play mka from the music library

@jmshrv
Copy link
Owner

jmshrv commented Feb 24, 2023

Hmm, what platform are you on? Android says that they support Matroska (https://exoplayer.dev/supported-formats.html), but I seriously doubt iOS does (Wikipedia says that macOS/QuickTime doesn't support it).

It would also be nice to know the underlying codec, i.e., FLAC, MP3 etc.

@Behem07h
Copy link
Author

Behem07h commented Feb 24, 2023

i'm on ios, and the audio codec is opus
i'm able to play most of my mka files just fine via the jellyfin client, so i'd be surprised to learn that ios doesnt support mka files (i say most because a select few of my mka files give me an incomptible media format error when played on jellyfin client, despite having the same audio codec and file extension as the rest. not sure why, but it isnt file corruption as the same file plays fine on desktop client)

@jmshrv
Copy link
Owner

jmshrv commented Feb 24, 2023

the audio codec is opus

Ah, that'll do it. iOS's native player only supports OPUS in the CAF container. As part of #215, I may add an option to remux OPUS files (OGG/OPUS, MKA/OPUS etc) to CAF for downloads so that iOS users don't have to convert their whole library. It may even be feasible to do this for streaming.

Also yeah Matroska can be a bit finicky with certain types of software, like how video editors never really supported it.

@Behem07h
Copy link
Author

Behem07h commented Mar 1, 2023

being able to play opus files without having to remux them all manually would be great

that said, it seems like vlc on ios is capable of playing both opus codec from other containers, and is capable of playing from matroska containers as well. i wonder whats up with that? do they not use the ios native player? since vlc is open source, i figure doing whatever they do would be an easier fix

@jmshrv
Copy link
Owner

jmshrv commented Mar 1, 2023

VLC for iOS comes with their own decoders and other playback stuff, so it can play much more than the native players (they get the same benefit on desktop). At some point, I'd like to do something similar with Finamp, probably with GStreamer or mpv (if their licenses would be compatible). The issue for that is at #177

@Behem07h
Copy link
Author

the issue i mentioned where mkv plays part wah and then resets to the beginning seems to be caused by jellyfin's streaming rather than the container format, as an identical bug happens here which can be circumvented by playing in offline mode leinelissen/jellyfin-audio-player#128

@Chaphasilor
Copy link
Collaborator

@Behem07h could you try this with the latest beta version? it should be supported now...

@Chaphasilor Chaphasilor added awaiting response / stale Issue is possibly outdated or waiting for user feedback and removed stale labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response / stale Issue is possibly outdated or waiting for user feedback
Projects
None yet
Development

No branches or pull requests

3 participants