Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Download button in long-press menu of library items #374

Closed
github-nicolas-stadler opened this issue Dec 28, 2022 · 4 comments
Labels
hacktoberfest Issues available for Hacktoberfest redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@github-nicolas-stadler
Copy link

Hey, for the sake of convenience, I would like to suggest some changes to the way the app manages downloaded tracks:

  • Add a "Download" button to the long-press menu of library items (artists, albums, playlists, genres, tracks).
  • Make said item "tagged" as downloaded instead of just being a one-time download. Items that are tagged as downloaded should managed themselves until I untag them. For example, if I add/remove/modify tracks in a downloaded playlist, the relevant files should be downloaded/removed/updated automatically so that I retain a locally accessible copy of the current state of that playlist (same logic with artists/albums and so on).

Thanks for the great app!

@github-nicolas-stadler github-nicolas-stadler changed the title [REQUEST] Download management improvement [Feature Request] Download management improvement Dec 28, 2022
@Chaphasilor
Copy link
Collaborator

This depends on #213 so it might take a while. But it's a very nice idea!

@jmshrv
Copy link
Owner

jmshrv commented Jan 3, 2023

Those are nice ideas, the first one would be very easy to implement and the second one has been a massive feature in the back of my head since I started working on this app 🙃

I really don't want to touch the download infrastructure until #213 is done, so yeah this will take a while. That bullet point is also a duplicate of #38, so I'll rename this issue to focus on the first one

@jmshrv jmshrv changed the title [Feature Request] Download management improvement [Feature Request] Download button in long-press menu of library items Jan 3, 2023
@Chaphasilor Chaphasilor moved this to Todo in Finamp Redesign Jun 23, 2023
@Chaphasilor Chaphasilor moved this from Todo to UI Issues - DONE in Finamp Redesign Jun 23, 2023
@Chaphasilor Chaphasilor added the hacktoberfest Issues available for Hacktoberfest label Oct 2, 2023
@Chaphasilor Chaphasilor moved this from UI Issues - DONE to Done in Finamp Redesign Jan 25, 2024
@Chaphasilor
Copy link
Collaborator

This will be part of the redesign beta, courtesy of @Komodo5197 :D

@Chaphasilor
Copy link
Collaborator

@github-nicolas-stadler the download system has been improved as part of the redesign beta. You can check it out here: https://github.com/jmshrv/finamp/releases/tag/0.9.2-beta

Playlists will be refreshed with the current changes on app startup, and I'll work on automatically syncing changes when editing a playlist or creating a new one!

I'll close this issue for now since it should be resolved.

@Chaphasilor Chaphasilor added the redesign-beta Issues related to the beta/redsigned version of Finamp label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues available for Hacktoberfest redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
Status: Done
Development

No branches or pull requests

3 participants