-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finamp does not transcode when the song's bitrate is below the transcoding bitrate #269
Comments
Could you check your Jellyfin logs for any transcoding errors? Discussion on new players is happening here: #177 |
No errors seen. I just switch the bitrate in the app to 160kbps and it worked. That doesn't seem like a very viable solution. I have to re-encode all my OPUS files to a higher bitrate than the bitrate I would like to listen to in order to try to avoid the artifacts generated by reencoding. If I do that I may as well switch the format so that I can use Finamp. |
I'll do some testing then, my guess is that Finamp is giving some incompatible transcoding option. Just wondering, how are you running Jellyfin? (Docker, Debian, Windows etc) |
I am using Docker on Ubuntu Server 22.04 LTS. |
I just tried using FLAC and it direct plays even with transcoding turned on. This could suck up some bandwidth. Any idea what I might be doing wrong? |
Is the file downloaded? I haven't heard any reports of that. |
No, just uploaded it to the server. |
How are you checking that the file is being direct played/transcoded? |
The dashboard page on the server says it is compatible and direct playing. |
Bottom left of app says streaming transcode. Which one is correct? |
Finamp is correct. You can verify this by checking for a transcode log in your server's logs menu. |
I think I've narrowed it down to this line: https://github.com/UnicornsOnLSD/finamp/blob/1ea614d9d55f7408ae14518351b055000d0c91d5/lib/services/music_player_background_task.dart#L532 The way Finamp tells Jellyfin to transcode is to set the max bitrate to the user settings. This works for FLACs, which are usually much higher than 320kbps, but for your OPUS music it doesn't. This also explains why it works when you drop the transcoding bitrate. A bandaid solution to this would be to set the max bitrate to the slightly below the song's bitrate when it's lower than the setting, but then you could lose out on quality as 160kbps AAC isn't great. As far as I know, this is the only way to enable transcoding with Jellyfin. I'll have a look to see if there's any other way, and if not, I may try adding an extra parameter to force transcoding at a specific bitrate. |
Thanks for the help. I am sorting through trying to understand the logs. Does jellyfin store transcoded files? I see some transcode logs but they only seem to be once for each file. If I start the songs again no knew file is created. Or is it Finamp storing a cached version of the song? |
I'm pretty sure Jellyfin caches transcodes for a bit, Finamp doesn't cache songs yet. |
Gotcha. Thanks! |
Fixed in 5316250 |
So, I already saw that OPUS is not suported on iOS but even with transcoding on the files will not play. I can play the file on my iPhone with Jellyfin app and with Web app on Firefox and Brave without transcoding. In Finamp the files will not play with or without transcoding.
The files I have are 192kbps. Does the bitrate on the transcoding section have to be below the encoded bitrate to work?
Is there any chance that the app will use another player, instead of Apple's built in one, so that OPUS will work? If not I am starting to think it would be best to just stick with the Jellyfin app.
The text was updated successfully, but these errors were encountered: