Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist items which aren't songs are shown and can be played #150

Open
rom4nik opened this issue Nov 22, 2021 · 1 comment
Open

Playlist items which aren't songs are shown and can be played #150

rom4nik opened this issue Nov 22, 2021 · 1 comment
Labels
hacktoberfest Issues available for Hacktoberfest

Comments

@rom4nik
Copy link
Contributor

rom4nik commented Nov 22, 2021

screen-20211122-045619-.00.00.000-00.17.021.-audio.mp4

...yeah. I'd expect Finamp (a music player) to either skip those non-music items, hide them or when there's no music in playlist at all, hide entire playlist. I don't have a good idea on how to solve this in an elegant and efficient way, though.
IMHO it would make sense to keep audiobooks playable (especially if explicit support for them is planned), but discard anything else like TV episodes, movies, etc.

@Chaphasilor
Copy link
Collaborator

Chaphasilor commented Sep 12, 2022

Well, and then there's #289 :D
So I guess you found a workaround for that issue, lol (although it's not actually playing anything for me, like it was for you)

I think this should be controlled by a toggle in settings, where the default is "hide non-music files"

@jmshrv jmshrv added the hacktoberfest Issues available for Hacktoberfest label Oct 12, 2022
@Chaphasilor Chaphasilor moved this to Todo in Finamp Redesign Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues available for Hacktoberfest
Projects
Status: Todo
Development

No branches or pull requests

3 participants