Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @fig/complete-commander an optional dependency to reduce bundle size #1116

Open
1 task done
hbsnmyj opened this issue Mar 30, 2024 · 0 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@hbsnmyj
Copy link

hbsnmyj commented Mar 30, 2024

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

Hi folks,

PR #1045 introduces a dependency to @fig/complete-commander, which pulls in prettier as a hard dependency. As of 3.12.5, prettier consumes 8.2 MiB spaces in prod builds, making depending on nest-commander much heavier than it should be.

Can we make it an optional dependency? Thanks a lot.

Describe the solution you'd like

Make @fig/complete-commander an optional dependency.

Teachability, documentation, adoption, migration strategy

No response

What is the motivation / use case for changing the behavior?

Reduce transitive closure of this package smaller.

@hbsnmyj hbsnmyj added the enhancement New feature or request label Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant