Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Display multiple lists when provided multiple options #1

Open
jmakhack opened this issue Mar 17, 2021 · 3 comments
Open

[FEATURE] Display multiple lists when provided multiple options #1

jmakhack opened this issue Mar 17, 2021 · 3 comments
Labels
C Requires a C code change enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue qualifies for the hacktoberfest event help wanted Extra attention is needed up for grabs This issue is available to take

Comments

@jmakhack
Copy link
Owner

jmakhack commented Mar 17, 2021

Currently the program will only display the list of the last option provided.

For example:

$ mya -wcdh jmak
onhold 2 anime
1. Commit on Titan
2. My Neighbor Octocat

This enhancement is to display all the lists provided within the options.

For example:

$mya -wcdh jmak
watching 1 anime
1. One Push Man

completed 3 anime
1. GitBoy
2. MasterBranch Z
3. MasterBranch Z: Season 2

dropped 1 anime
1. Re:Base

onhold 2 anime
1. Commit on Titan
2. My Neighbor Octocat
@jmakhack jmakhack added enhancement New feature or request good first issue Good for newcomers up for grabs This issue is available to take labels Mar 17, 2021
@jmakhack jmakhack changed the title Display multiple lists when provided multiple options [FEATURE] Display multiple lists when provided multiple options Mar 21, 2021
@jmakhack jmakhack added the C Requires a C code change label Apr 10, 2021
@jmakhack
Copy link
Owner Author

jmakhack commented Oct 22, 2021

Please comment below if you have any questions or would like to pick up this issue to count towards the hacktoberfest event. First person to comment will get assigned this issue.

@jmakhack jmakhack added hacktoberfest This issue qualifies for the hacktoberfest event help wanted Extra attention is needed labels Oct 22, 2021
@jmakhack jmakhack removed the hacktoberfest This issue qualifies for the hacktoberfest event label Sep 30, 2022
@jmakhack jmakhack added the hacktoberfest This issue qualifies for the hacktoberfest event label Oct 9, 2022
@sameersecond
Copy link
Contributor

This would probably require changing the enum in the arguments struct to either individual fields or making a nested struct containing the different modes. Is there any other approach you can think of? I can work on this issue.

@jmakhack
Copy link
Owner Author

@sameersecond, the first approach that came to mind when writing this was splitting up the enum into multiple fields similar to the SFW option you worked on.

The other approach of creating a nested struct containing the different modes may actually be nicer though since it keeps all the "mode" options together in a single data structure. No other approaches come to mind at the moment. I'm open to any approaches for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Requires a C code change enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue qualifies for the hacktoberfest event help wanted Extra attention is needed up for grabs This issue is available to take
Projects
None yet
Development

No branches or pull requests

2 participants