Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion: Transparent or colorized juggler body #130

Open
noslowerdna opened this issue May 28, 2023 · 1 comment
Open

Feature suggestion: Transparent or colorized juggler body #130

noslowerdna opened this issue May 28, 2023 · 1 comment

Comments

@noslowerdna
Copy link

Occasionally there are patterns where the forearm briefly passes behind the body for a frame or few, leaving a 'blip' in the animation as it disappears then reappears. So I often find myself adjusting the Y coordinate forward for certain throw or catch events to avoid this.

I would suggest an option to render the juggler's body as transparent (or maybe any color, now that transparent is supported, with the default remaining white).

@noslowerdna noslowerdna changed the title Feature suggestion: Transparent or color juggler body Feature suggestion: Transparent or colorized juggler body May 29, 2023
@jkboyce
Copy link
Owner

jkboyce commented May 29, 2023

The idea here is allowing a user-defined color for painting the body (and head) of the juggler. (Specifically the fill color, not the outline color.) There are two ways this could be added:

  1. As a setting in Animation Preferences. There is currently a hidejugglers setting that hides all painting for a juggler. There could be a related animation setting to define color on a per-juggler basis, potentially subsuming hidejugglers.
  2. As a pattern-setting variable, which would then be represented in the JML version of the pattern. The natural thing would be to add an optional JML tag akin to <prop type="ball" mod="color=green"/> but for juggler definitions. The <setup> tag format would be adjusted to make reference to these juggler definitions, the same way it is done for props.

The first approach would be easier to implement, but the second approach would be more general and allow for future changes to juggler drawing style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants