[syncoid] Wrong arguments order for 'zfs get all'

[Peter2121]

There is an error in function getlocalzfsvalues.

The command should be:
$rhost $mysudocmd $zfscmd get -s local -H all $fsescaped

(argument all must be just before the dataset/volume name).

The actual function is always failed:

cannot open '-s': dataset does not exist
cannot open 'local': dataset does not exist
cannot open '-H': dataset does not exist

The OS version is FreeBSD 14.2.
ZFS version is 2.2.6-FreeBSD_g33174af15.

[phreaker0]

The linked line already looks like the way you suggest, can you explain a little more?

[Peter2121]

Hmm... Strange...

In /usr/local/bin/syncoid version 2.2.0 installed from package https://www.freshports.org/sysutils/sanoid/ I see:

if ($debug) { print "$rhost $mysudocmd $zfscmd get all -s local -H $fsescaped\n"; }
        system("$rhost $mysudocmd $zfscmd get all -s local -H $fsescaped");

I see the same code in the tarball of 2.2.0 release. But, indeed, it is already fixed in master branch (but I cannot find the commit that fixed it).

So, finally, please release the fixed version and update the FreeBSD port.