Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] - Add support for knn_vector mapping type - required for opensearch #146

Open
chirag4semandex opened this issue Jul 1, 2024 · 1 comment

Comments

@chirag4semandex
Copy link

Describe the enhancement

Currently, you have support for dense_vector type for supporting the KNN search. This works fine with elastic search but for OpenSearch, it uses knn_vector type.

I cannot find a way to use OpenSearch knn_vector type using this. The main reason is that in Opensearch, it's a plugin, and since it's a plugin, it requires special settings, something like the below, and currently your IndexSettings class has no such support.

"settings": {
    "index": {
      "knn": true
    }
  }

Why is this needed?

This is needed to make use of KNN search plugin using OpenSearch.

How do you think it should be done?

The easiest way would be to add a field in the IndexSettings class for KNN plugin-related information.

Another option for supporting other such plugins related settings is to make the IndexSettings class open so that people can extend it and provide whatever settings are needed.

Will you be able to help with a pull request?
Sure

Optional, but do let me know if you plan to do work.
Yes

@jillesvangurp
Copy link
Owner

Sounds good. I've been meaning to look at opensearch support for this in any case. Just super busy with other stuff lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants