Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: GH action: backend #409

Closed
5 of 7 tasks
Tracked by #414
joeflack4 opened this issue Jun 18, 2023 · 0 comments · Fixed by #527
Closed
5 of 7 tasks
Tracked by #414

Tests: GH action: backend #409

joeflack4 opened this issue Jun 18, 2023 · 0 comments · Fixed by #527
Assignees
@joeflack4
Labels
new feature New feature or request qa / test
Milestone
1. Most important...

Comments

@joeflack4
Copy link
Member

joeflack4 commented Jun 18, 2023 •
edited
Loading

Overview

In order to prevent things from breaking, it would be good to run our unit tests more frequently / in automated fashion.

Sub-task list

  • 1. Create the basic action
  • 2. When to run
  • 3. What to run
  • 4. Test passing/failing badge
  • 5. Get it to pass (opted to do this in a separate PR)

Sub-task details

2. When to run

  • Daily?
  • On pull requests
  • On push to dev?

3. What to run

  • Simple/all backend tests
  • Simple/all frontend tests?

5. Get it to pass

Right now the tests are a mess. Many old and not up-to-date with recent changes and will probably fail. Others half finished. Need to:

  • i. Deactivate any tests that aren't ready / updated enough to run (fixing these is a separate issue). Probably best way to do this is through a decorator like @dontrun or something (OAK does this so I can borrow their code), or a config variable, something like RUN_UNFINISHED_TESTS, and could have an if statement that checks that at the beginning of the test.
  • ii. Fix any tests that are failing but can be fixed quickly
@joeflack4 joeflack4 added the new feature New feature or request label Jun 18, 2023
@joeflack4 joeflack4 moved this to Todo in TermHub Jun 18, 2023
@hugwuoke hugwuoke mentioned this issue Jun 29, 2023
Closed
1 task
@hugwuoke hugwuoke removed this from TermHub Jun 29, 2023
@joeflack4 joeflack4 changed the title GitHub action for unit tests Automated testing on GitHub: action for unit tests Aug 12, 2023
@joeflack4 joeflack4 self-assigned this Aug 12, 2023
@github-project-automation github-project-automation bot moved this to Todo in TermHub Aug 12, 2023
@joeflack4 joeflack4 linked a pull request Aug 19, 2023 that will close this issue
Tests: GH action: backend #527
Merged
@joeflack4 joeflack4 changed the title Automated testing on GitHub: action for unit tests Tests: GH action: backend Sep 14, 2023
@joeflack4 joeflack4 moved this from Todo to In progress / sprint in TermHub Sep 14, 2023
@joeflack4 joeflack4 mentioned this issue Sep 18, 2023
Closed
@joeflack4 joeflack4 moved this from In progress / sprint to Soon in TermHub Sep 18, 2023
@joeflack4 joeflack4 moved this from Soon to In progress / sprint in TermHub Oct 9, 2023
@joeflack4 joeflack4 moved this from In progress / sprint to Soon in TermHub Oct 13, 2023
@joeflack4 joeflack4 moved this from 2. Soon to 1. In progress / sprint in TermHub May 24, 2024
@github-project-automation github-project-automation bot moved this from 1. In progress / sprint to 5. Done in TermHub May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeflack4 joeflack4

Labels
new feature New feature or request qa / test
Projects
TermHub
Status: 5. Done
Milestone
1. Most important test issues
Development

Successfully merging a pull request may close this issue.

Tests: GH action: backend jhu-bids/TermHub
1 participant
@joeflack4