update megaraid_serial fact to deal with SM motherboards #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 21, 2014 17:41
Per #29, the LSI controller on at least some models of SuperMicro motherboards does not report a serial number. The megaraid_serial fact has not gracefully handling this case and facter was generating errors.
jhoblitt
pushed a commit
that referenced
this pull request
May 22, 2014
update megaraid_serial fact to deal with SM motherboards
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #29, the LSI controller on at least some models of SuperMicro
motherboards does not report a serial number. The megaraid_serial fact
has not gracefully handling this case and facter was generating errors.