Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Poetry build tool via JFrog CLI #1410

Open
earndt-BRONGA opened this issue Jan 27, 2022 · 9 comments
Open

Support for Poetry build tool via JFrog CLI #1410

earndt-BRONGA opened this issue Jan 27, 2022 · 9 comments
Labels
feature request New feature or request

Comments

@earndt-BRONGA
Copy link

Is your feature request related to a problem? Please describe.
At present, the JFrog CLI does not natively support attaching build metadata to Python packages built using Poetry in a manner similar to other build tools (consider the --build-name and --build-number options passed to the jfrog rt gradle command.)

Describe the solution you'd like to see
The addition of commands such as jfrog rt poetry and jfrog rt poetry-config isomorphic to those provided for other build tools (e.g. jfrog rt pip, jfrog rt gradle, jfrog rt npm) and subsequent recognition of those commands' by extant JFrog CLI commands (build-publish, build-scan, build-promote &c.)

Describe alternatives you've considered
We've considered converting our existing Poetry projects to Pip, however this is not feasible at this time.

@earndt-BRONGA earndt-BRONGA added the feature request New feature or request label Jan 27, 2022
@joergsesterhenn
Copy link

We were informed by JFrog Support this is currently planned for 09/2022. Looking forward to being able to use poetry with artifactory/xray.

@joergsesterhenn
Copy link

@sverdlov93 @talarian1 is this issue closed with release 2.27.0 ?

@joergsesterhenn
Copy link

This still needs at least some documentation here, right?

@eyalbe4
Copy link
Contributor

eyalbe4 commented Oct 4, 2022

@joergsesterhenn - although the code that supports Poetry is technically released, the documentation for it is still being worked on. It documentation will become available soon. We'll share an update here when it does.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Nov 3, 2022

@joergsesterhenn -
Unfortunately the new build-info functionality we built in JFrog CLI broke following the removal of a file which used to be generated by Poetry. We're trying to get the help of the Poetry Team as you can see in https://github.com/orgs/python-poetry/discussions/6869.

@joergsesterhenn
Copy link

Our initial goal was to introduce build-info support for Poetry, but at the end of the development effort, we were forced to stop due to the issue discussed here. As much we want to get back to this (we feel this addition is important), our current focus was shifted to other areas. Hopefully we'll be able to get back to this in the near future.

@eyalbe4 Any idea on when you will be able to look at this again? We curently run an additional pip install of our dependencies just to collect them for xray. That is quite costly and we really want this to be fixed timely.

@ckmeichs
Copy link

We are also facing this problem and would be happy about a solution.

@drobert-bfm
Copy link

I will add that using pip isn't viable, since pip doesn't respect the lock file. We really need to ensure that the dependency versions listed in the lock file are the ones used for the build-info.

@broglep-work
Copy link

What is the current state / stance on supporting poetry? We would like to use JFrog CLI with Poetry

After our initial look at it, it is quite confusing. Official documentation mentions support
for poetry and current version of cli seems to kind of work (we have not fully tested it), but on the other hand poetry example got removed mentioning that it is not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants