Remove Windows support #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will let this PR open for some time in order to allow people to comment on #101. I don't expect any problems, though. |
Since valgrind is only available on POSIX-systems, but crucially not on Windows as [documented here][docu]. Therefore it doesn't make much sense to compile for Windows, when the underlying tool is not available. Not supporting Windows might be beneficial for development, e.g. one can use [`nix`] for POISX-functionality not available on Windows. Note, that valgrind also support Android and similar, but this is not relevant for this commit, as there is already no testing for those plat- forms anyways. [docu]: https://valgrind.org/info/platforms.html [`nix`]: https://crates.io/crates/nix
jfrimmel
force-pushed
the
remove-windows-support
branch
from
7462506 to
f92d9c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the CI-jobs, that build on Windows, effectively allowing for non-portable code in the future.
Since valgrind is only available on POSIX-systems, but crucially not on Windows as documented here. Therefore it doesn't make much sense to compile for Windows, when the underlying tool is not available. Not supporting Windows might be beneficial for development, e.g. one can use
nixfor POISX-functionality not available on Windows.Closes #101.