Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update Snapshot is displayed in test item menu #1207

Open
oxdev03 opened this issue Dec 15, 2024 · 0 comments
Open

[BUG] Update Snapshot is displayed in test item menu #1207

oxdev03 opened this issue Dec 15, 2024 · 0 comments

Comments

@oxdev03
Copy link

oxdev03 commented Dec 15, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Open a project using vitest
  2. right click on test item
  3. "Update Snapshot button is displayed from jest"

Expected behavior
The Update Snapshot Button is only displayed for jest tests. It can be quite disturbing, if the button is accidently pressed, which activates the jest extension for the project.

Screenshots
If applicable, add screenshots to help explain your problem.
Image

Environment (please complete the following information):

  • vscode-jest version:latest , default settings

Additional context
Will adding "when": "controllerId == 'jest'" to testing/item/gutter and testing/item/context fix the issue or is there a background why its not used yet?

I can open a PR, if the suggested fix is sufficient to resolve the issue.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant