Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixed Imperial and U.S. fluid ounce sizes. #6

Open
vvanpo opened this issue May 2, 2018 · 0 comments
Open

Mixed Imperial and U.S. fluid ounce sizes. #6

vvanpo opened this issue May 2, 2018 · 0 comments
Assignees
@vvanpo

Comments

@vvanpo
Copy link
Contributor

vvanpo commented May 2, 2018

'Large Can 16 oz' uses US fluid ounces, whereas 'Small Can 12.5 oz' uses Imperial. All sizes should be US, since this is standard.
vvanpo added a commit to vvanpo/beneverages that referenced this issue May 2, 2018
@vvanpo
Make fluid ounce usage consistent to US fl. oz.
7689cdc 
This fix changes all uses of fluid ounces to be US fl. oz., whereas
before it was a mix of Imperial and US. It also introduces automatic
millilitre calculation, and adds the litre unit as an option.

Provide the option to display just oz, just mL, or both, with automatic
conversion to L for sizes above 1000 mL inclusive.

Fixes issue jenreiher#6.
@vvanpo vvanpo mentioned this issue May 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvanpo vvanpo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vvanpo