Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Missing docker tag results in un-actionable error message #142

Open
martinda opened this issue Aug 22, 2020 · 1 comment
Open

Missing docker tag results in un-actionable error message #142

martinda opened this issue Aug 22, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@martinda
Copy link
Contributor

When the docker tag is not provided, the application is unable to produce a WAR file and reports: "This is something wrong with your configuration file. Please fix and try again"

In the console, the error is more descriptive:

2020-08-22 12:05:37.809  INFO 7194 --- [nio-8080-exec-7] i.j.t.w.lib.util.DockerfileBuilder       : Building Docker image 
invalid argument "" for "-t, --tag" flag: invalid reference format
See 'docker build --help'.
2020-08-22 12:05:38.118 ERROR 7194 --- [nio-8080-exec-7] c.o.j.c.j.d.service.PackagerController   : java.io.IOException: Command failed with exit code 125: docker build -t  .

However, when the service is hosted, users do not have access to the console messages. Users will not know what is wrong. The error needs to be raised all the way to the user interface. This error can be prevented by forcing the user to enter a valid docker tag name in the package configuration pop-up, not not let the user close the pop up

@martinda martinda changed the title Missing tag silent error needs to send a error message to the user Missing docker tag results in un-actionable error message Aug 22, 2020
@sladyn98
Copy link
Contributor

Yeah we would need to attach the error message to the 404 being thrown.

@sladyn98 sladyn98 added the enhancement New feature or request label Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants