Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jenkins X repositories to go 1.23 #8670

Open
20 of 30 tasks
msvticket opened this issue May 20, 2024 · 28 comments
Open
20 of 30 tasks

Upgrade Jenkins X repositories to go 1.23 #8670

msvticket opened this issue May 20, 2024 · 28 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed in progress kind/task Activity or chore which needs to be done

Comments

@msvticket
Copy link
Member

msvticket commented May 20, 2024

When we were upgrading the go version to 1.18, we noticed that we are limited by the version of go in the goreleaser image. We are now building a custom image where we can set the version of go and install other packages we need. Once that is done, we can start this update work.

Golang supports only 2 major releases: https://endoflife.date/go
The latest version of golang is 1.23

Follow this guide for information on how to upgrade: https://jenkins-x.io/community/maintainer_guide/go-upgrades/

Before upgrading , we need to upgrade the version of golang in the catalog repository:
example (there are other files as well): https://github.com/jenkins-x/jx3-pipeline-catalog/blob/0f0f956d38ffe383ba38d93c1cfe7160a3bec93a/tasks/go/pullrequest.yaml#L37

This is the tentative list of repositories (list will be updated if we find any missing repositories) that we should upgrade:

In the list, there are some packages which need multiple packages updated before we update them, for example: before upgrading jx-api we should upgrade jx-logging.

NOTE: it's fine if you dont follow the order, the order is only there to limit the number of PRs we open as part of an upgrade effort

We will this issue to keep track of which repositories have been or are in the process of being upgraded.
If you are interested in contributing, please comment

I want to upgrade <repo-name>

When opening a PR in these repos to upgrade the go version, remember to include

related to jenkins-x/jx#8670

Don't use fixes as that will close this issue once your PR is merged.
Once your PR is merged, comment in this issue:

<reponame> has been upgraded to 1.23
@msvticket
Copy link
Member Author

I want to upgrade go-scm

msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/jx3-pipeline-catalog that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/jx3-versions that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/jx-kube-client that referenced this issue Jun 4, 2024
also linting fixes

related to jenkins-x/jx#8670
@msvticket
Copy link
Member Author

I want to upgrade jx-kube-client

msvticket added a commit to jenkins-x/logrus-stackdriver-formatter that referenced this issue Jun 4, 2024
make test failures more readable

partly reverting stackskip_test.go to a state that shouldn't need updating on every go upgrade

related to jenkins-x/jx#8670
@msvticket
Copy link
Member Author

I want to upgrade logrus-stackdriver-formatter

msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 5, 2024
msvticket added a commit to jenkins-x/logrus-stackdriver-formatter that referenced this issue Jun 5, 2024
@msvticket
Copy link
Member Author

I want to upgrade lighthouse

msvticket added a commit to jenkins-x/lighthouse that referenced this issue Jun 5, 2024
also fixing linting

related to jenkins-x/jx#8670
@msvticket
Copy link
Member Author

go-scm has been upgraded to 1.22.3

msvticket added a commit to jenkins-x/lighthouse that referenced this issue Jun 5, 2024
also fixing linting

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x/lighthouse that referenced this issue Jun 5, 2024
also fixing linting

related to jenkins-x/jx#8670
@msvticket
Copy link
Member Author

lighthouse has been upgraded to 1.22.3

msvticket added a commit to jenkins-x/jx-kube-client that referenced this issue Jun 5, 2024
also linting fixes

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x/jx-kube-client that referenced this issue Jun 5, 2024
also linting fixes

related to jenkins-x/jx#8670
@msvticket
Copy link
Member Author

Upgrading jx-secret

msvticket added a commit to jenkins-x-plugins/jx-changelog that referenced this issue Oct 10, 2024
msvticket added a commit to jenkins-x-plugins/jx-secret that referenced this issue Oct 10, 2024
msvticket added a commit to jenkins-x-plugins/jx-secret that referenced this issue Oct 10, 2024
msvticket added a commit to jenkins-x-plugins/jx-secret that referenced this issue Oct 10, 2024
msvticket added a commit to jenkins-x-plugins/jx-secret that referenced this issue Oct 10, 2024
msvticket added a commit to jenkins-x-plugins/jx-secret that referenced this issue Oct 10, 2024
msvticket added a commit to jenkins-x-plugins/jx-changelog that referenced this issue Oct 10, 2024
msvticket added a commit to jenkins-x-plugins/jx-secret that referenced this issue Oct 10, 2024
msvticket added a commit to jenkins-x-plugins/jx-changelog that referenced this issue Oct 10, 2024
msvticket added a commit to jenkins-x-plugins/jx-changelog that referenced this issue Oct 10, 2024
msvticket added a commit to jenkins-x-plugins/jx-secret that referenced this issue Oct 10, 2024
@msvticket
Copy link
Member Author

jx-admin is upgraded

@msvticket
Copy link
Member Author

Due to a security fix in net/http in go 1.22.8 some libraries has that as minimum requirement. So I'll add update our pipelines and goreleaser to support that. I'll add support for the latest version while at it.

msvticket added a commit to deniedboarding/jx3-pipeline-catalog that referenced this issue Oct 11, 2024
msvticket added a commit to jenkins-x-plugins/jx-changelog that referenced this issue Oct 11, 2024
also increaae lint timeout

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x-plugins/jx-context that referenced this issue Oct 11, 2024
msvticket added a commit to deniedboarding/jx3-pipeline-catalog that referenced this issue Oct 14, 2024
msvticket added a commit to jenkins-x/jx3-versions that referenced this issue Oct 14, 2024
msvticket added a commit to jenkins-x/bucketrepo that referenced this issue Oct 23, 2024
also removing a couple of unused files

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x/jx-git-operator that referenced this issue Oct 23, 2024
msvticket added a commit to jenkins-x/jx-git-operator that referenced this issue Oct 23, 2024
@msvticket msvticket changed the title Upgrade Jenkins X repositories to go 1.22 Upgrade Jenkins X repositories to go 1.23 Oct 29, 2024
@msvticket msvticket self-assigned this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed in progress kind/task Activity or chore which needs to be done
Projects
Status: In progress
Development

No branches or pull requests

3 participants