Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a speech bubble in user story page #8

Open
lemeurherve opened this issue Jun 14, 2022 · 5 comments · May be fixed by #84
Open

Add a speech bubble in user story page #8

lemeurherve opened this issue Jun 14, 2022 · 5 comments · May be fixed by #84
Labels
enhancement New feature or request

Comments

@lemeurherve
Copy link
Member

Current design image

At first I wanted to suggest aligning the avatar block to the left as I thought it was the header of the text below, then I realized it was centered as related to the citation in the middle of the page.

I suggest adding some sort of speech bubble or other background/highlight around the citation, for example: https://codepen.io/grayghostvisuals/pen/GqzRox

@halkeye
Copy link
Member

halkeye commented Jun 15, 2022

You have no idea how long I spent on that. I couldn't pull in the exact styles that the original site used as they were wordpress wysiwyg.

I'm happy if it gets improved though I don't see me poking at it anymore.

I swear I had a version like https://csshint.com/bootstrap-quotes/ with the big quotes working at some point. I feel like I lost it when I was trying to get mdx working, and before i settled on the full yaml version.

@lemeurherve lemeurherve added the enhancement New feature or request label Jun 15, 2022
@biru-codeastromer
Copy link
Contributor

biru-codeastromer commented Jan 15, 2025

Hi Sir @krisstern ,

I hope this message finds you well.
I’m currently working on #4 , and I noticed that issue #8 (Add a speech bubble in user story page) is still open . I believe I can contribute a solution for that issue as well. If it is still open please let me know .

Would it be alright if I work on both simultaneously and submit a PR for #8 while continuing with my work on PR #80?
I’ll ensure that both contributions are handled carefully and won’t conflict with each other.

Looking forward to your guidance regarding this!

@krisstern
Copy link
Member

Hi @biru-codeastromer you are welcome to work on this issue

@biru-codeastromer
Copy link
Contributor

Hi @biru-codeastromer you are welcome to work on this issue

Thank you very much for the confirmation Sir !

@biru-codeastromer
Copy link
Contributor

Hi @biru-codeastromer you are welcome to work on this issue

Thank you Sir so much for the opportunity to work on this issue! As requested, I’ve generated PR #84 to address the problem. I’ve now shifted my focus to this issue and will prioritize it before moving back to #5, if it’s still open.

Looking forward to your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants