Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon computer-x #2

Open
aklein-dex opened this issue Feb 10, 2016 · 4 comments
Open

Icon computer-x #2

aklein-dex opened this issue Feb 10, 2016 · 4 comments

Comments

@aklein-dex
Copy link

It seems that there is no icon for computer-x.
If you go to the "Nodes" section, you can see a table with all the nodes. When a node is offline, you should see an image with a "x" on it. But with your theme, no image is displayed. Here is the html code:

<td width="32" data="computer-x.png">
    <img class="icon-computer-x icon-lg" style="width: 32px; height: 32px; " alt="[offline]" src="/static/6fbf67a5/images/32x32/computer-x.png">
</td>

However, when a node is online, this image is displayed correctly:

<td width="32" data="computer.png">
    <img class="icon-computer icon-lg" style="width: 32px; height: 32px; " alt="[online]" src="/static/6fbf67a5/images/32x32/computer.png">
</td>
@afonsof
Copy link
Member

afonsof commented Feb 10, 2016

@aklein-dex this bug was already fixed in this commit in the jenkins-material-theme repo: afonsof/jenkins-material-theme@d7ca378

@afonsof
Copy link
Member

afonsof commented Feb 10, 2016

.icon-computer-x {
   .icon-img('../images/computer_offline.svg', @color-grey);
 }

 .icon-new-computer {
   .icon-img('../images/computer_new.svg', @color-grey);
 }

@aklein-dex
Copy link
Author

Nice, thank you!

@afonsof
Copy link
Member

afonsof commented Feb 12, 2016

@aklein-dex I guess it was not fixed here yet. Only in the another theme jenkins-material-theme.

@aklein-dex aklein-dex reopened this Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants