Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music lyrics for right-to-left languages are incorrectly aligned to the left #6391

Open
ebkalderon opened this issue Dec 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ebkalderon
Copy link

ebkalderon commented Dec 16, 2024

Describe The Bug

The following pages in the Jellyfin Web client (and Jellyfin for Android) incorrectly left-align lyrics for languages right-to-left text, e.g. Arabic and Hebrew:

  • https://<host:port>/web/#/lyrics
  • https://<host:port>/web/#/details?id=<id>

Additionally, if a given row of lyrics contains a mixture of right-to-left text and Western punctuation (with or without Latin characters present as well), the text becomes completely garbled and difficult to read.

Steps To Reproduce

  1. Right-click on any music track within a given music album.
  2. Click Edit lyrics in the context menu.
  3. Search for and/or upload an LRC file containing right-to-left text.
  4. Right-click on the music track and select View lyrics. This navigates to https://<host:port>/web/#/details?id=<id>.
  5. See screenshot 1 below.
  6. Start playing the track in the music player.
  7. Repeat step 4. This navigates to https://<host:port>/web/#/lyrics.
  8. See screenshot 2 below.

Expected Behavior

Lyrics should be right-aligned instead of left-aligned, and trailing punctuation should be rendered in the correct text position at the end of the sentence (left edge) rather than at the start of the sentence (right edge).

Additionally, rows of lyrics containing mixed RTL and LTR text should correctly switch text direction within the same sentence. For instance, this incorrectly rendered bi-directional lyric in Jellyfin Web:

Image

should instead be displayed as:

Image

This transformation should occur regardless of the user's selected display language for Jellyfin Web and/or Jellyfin for Android.

Logs

N/A

Screenshots

Image
Image

System (please complete the following information):

  • Platform: Linux
  • Browser: Firefox 133.03
  • Jellyfin Version: 10.10.3
  • Jellyfin Web Version: 10.10.3 (b95dad4ba2)

Additional Context

@ebkalderon ebkalderon added the bug Something isn't working label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant