Hide Collections from 'Allow Deletion From' Setting #6361
Labels
bug
Something isn't working
Comments
5 tasks
JPKribs
added a commit
to JPKribs/Swiftfin
that referenced
this issue
Dec 6, 2024
This was referenced Dec 6, 2024
LePips
added a commit
to jellyfin/Swiftfin
that referenced
this issue
Dec 6, 2024
…#1336) * Cleanup / Genre & Tag Management * Move searching to a backgroundState. Fix the font Color when bulk editing tags / genres should be secondary when editing & not selected * Cleanup * Now that cancelling is handled better this should prevent the issue where the suggestions fails to update on a letter entry * Change from using an event for searchResults to using a published searchResults var * Moved all logic to a local list where all genres/tags are populated on refresh then filterd locally instead of calling the server for changes. * Inheritance * Split metadata from components then alphabetize. Also, fix but where you can't add a people * People & Permissions * Functional but dirty. TODO: Cleanup + Trie? Trei? * nil coalescing operator is only evaluated if the lhs is nil, coalescing operator with nil as rhs is redundant * TODO: Search improvements & Delay search on name change * Cleanup & reordering * Debouncing * Trie implementation * Permissions Cleanup Squeezing in: jellyfin/jellyfin-web#6361 * enhance Trie * cleanup * cleanup --------- Co-authored-by: Ethan Pippin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe The Bug
Permission to enable collection deletion is handled by the isAdministrator flag. Adding Collections to a user doesn't grant the ability to delete and removing it doesn't restrict access. Only Admins can delete collections.
Steps To Reproduce
Create/use a non-admin
Grant 'Allow Media Deletion From' Collections
This user still cannot delete Collections
Create/use a admin
Revoke 'Allow Media Deletion From' Collections
This user still delete Collections
Expected Behavior
The behavior makes sense since Collections aren't 'real' files. It makes sense deleting these is an Admin function but we should just probably hide Collections from the 'Allow Media Deletion From' since it doesn't do anything if it's enabled/disabled.
System (please complete the following information):
Additional Context
Entirely just cosmetic. I just found this interaction when I was doing jellyfin/Swiftfin#1333. I need to filter Collections from my list too but I wanted to try and make it consistent between platforms.
The text was updated successfully, but these errors were encountered: