Music Visualiser option during full screen music playback.

[flip-dots]

I thought it would be cool if there was a music visualiser as an option when you full screen music so I threw together a quick prototype to see if it was possible and I think the results are pretty cool.

I think the library I used uses a compatible licence so I think it should be ok on that front, and if you want to see some of the possibilities there is a demo site for the library.

So before I spend much more than an afternoon on it, if done correctly is this a feature that you guys would accept?

[ferferga]

I think stuff like this has come up already in the past, and I don't think we ever had anything against it.

We didn't ever work on it since lately we're basically all in with refactors and stabilise the code, but it's something I (as a primary music user) myself wanted. We want to make an adaptable app for every media type as listed in our roadmap, and we have a fullscreen music page we can enrich, so why not? :P

I prefer more subtle effects (I'm more of background colors vibrating) but that's probably something we can let users configure once we have some settings pages done (wanna help with those too after this? :P). For now on, I think a button in the app bar at the left that lets you toggle between the current album view and this is fine.

As long as you do a good implementation (this is what the PR review process is for) and the library you use can be extended for other effects (so we can expand them in the future to cater different tastes. If not, please find others, I did my research back in the day and there are a lot of these libraries) you have my ✅.

Thoughts @ThibaultNocchi ?

[ferferga]

@flip-dots Any update about this?

[flip-dots]

I cleaned up the code a while ago and it seems to work ok, but I haven't submitted a pull request yet because I don't currently have the time to fix my inevitable mistakes due to university exams. I will be free of those in a week, so I plan on dealing with it all then. If i'm not super busy this summer I might be able to help out with the setting pages but I don't control my procrastination demon, so no promises. :)

[ferferga]

@flip-dots No worries, I'm in the same situation as you, so I understand perfectly. Took the plunge today to do some cleanup of dependency updates, but now I'm back to study :).

Just wanted to be sure that we had you on board and you didn't had any problem 🙌!

Wish you luck for your exams!

[ferferga]

Added in #2043