-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow HTTP redirect when discovering servers #769
Comments
Quoting from a reply to a similar recent question:
We do have support for following redirects in the SDK but it's always disabled during discovery and our official apps always disable it. We should at the very least change the error message to say something like "ignored redirect for candidate X" and preferably follow the redirect while testing and if it redirects to a valid server show a pop-up to the user to confirm if the address redirected to is valid. |
Looking at the issues now I believe this is really a duplicate of #471 so I'll close this one. |
I'm modified |
I'm following up on an issue I described in jellyfin/jellyfin-android#949 (comment). I've an HTTP redirect set from a custom domain to the Jellyfin server. Works great on browsers with both HTTP and HTTPS, even on LG webos app. The android client, however, refuses to follow the redirect URL and instead lists the tried candidates:
Could it be possible to allow redirected URLs (301/302) to be acceptable as server URLs instead of outright rejecting them? I believe it could be fixed by adjusting the acceptable response code here: https://github.com/jellyfin/jellyfin-sdk-kotlin/blob/master/jellyfin-core/src/commonMain/kotlin/org/jellyfin/sdk/discovery/RecommendedServerDiscovery.kt#L125.
The text was updated successfully, but these errors were encountered: