Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remux DoVi MKV to MP4 #685

Closed
Terebi42 opened this issue Jul 6, 2022 · 7 comments · Fixed by #1989
Closed

remux DoVi MKV to MP4 #685

Terebi42 opened this issue Jul 6, 2022 · 7 comments · Fixed by #1989
Labels
enhancement New feature or request

Comments

@Terebi42
Copy link

Terebi42 commented Jul 6, 2022

Describe the feature you'd like
The TCL Roku TVs (and possibly Roku Boxes?) support Dolby vision, but only in MP4 containers.

If Jellyfin would remux the mkv to mk4 and preserve the DoVi, it would dramatically increase compatibility for playback.

This is apparently already done in the Safari client, see https://imgur.com/a/MbvAgjy

Additional context
I have test files available that work in TCL Roku (mp4 trigger DoVi) on plex or jellyfin

and I have files that come across purple in PLEX, but fail to render at all in Jellyfin (mkv)

I can provide release names privately if needed.

@Terebi42
Copy link
Author

Terebi42 commented Jul 6, 2022

m2ts container might also be an ok target, that may have less limitations than mp4

@cewert cewert added the enhancement New feature or request label Jul 11, 2022
@whiteowl3
Copy link
Contributor

ive done some preliminary work on supporting different HDR levels to facilitate a discussion on how HDR support should be implemented. #686 in its current state this pr at least appears to report the correct video level support, and to transcode or not transcode for the correct reason, but testing of this on other setups would help, as well as discussing the actual structure of the implementation.

@Terebi42
Copy link
Author

Terebi42 commented Jul 12, 2022

but testing of this on other setups would help

I'm happy to test, but am a .net dev, so have no idea how to build or deploy the jellyfin client to my roku

ed : ah, the devguide doesn't look too bad. Ill pull down the code and test once the PR gets merged

@whiteowl3
Copy link
Contributor

a device profile of safari on ios12 remuxing an mkv for "ContainerNotSupported":
https://pastebin.com/raw/BFjXuFUB

@tiagogaspar8
Copy link

tiagogaspar8 commented Jul 30, 2022

This, please, it would allow us to have our libraries in nice juicy mkv, but not only for ruku, this applies to almost all platforms

@whiteowl3
Copy link
Contributor

whiteowl3 commented Aug 1, 2022

from chat:
zackoid

it's common for DV to only be supported in mp4 containers. so if you can accurately detect the presence of DV there wouldn't be any harm in remuxing whenever it is present. i don't think a standard remux translates all the metadata correctly so that is probably something that can't be handled on the roku end alone, but i'm not certain about that.

@Terebi42
Copy link
Author

Terebi42 commented Aug 1, 2022

re "standard remux", this tool does the work for offline transcoding. Not sure if/how this could be done from inside jellyfin, but they are both ultimately shelling out to ffmpeg?

https://github.com/gacopl/dvmkv2mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants